CI: Fix installation of defined SQLAlchemy version, bringing back SA13 #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The order of operations was wrong. So, previously, the process would always install SQLAlchemy 1.4, skipping testing on SQLAlchemy 1.3.
4532ef7 started using the `PGCompiler` for generating limit clauses, to be more compatible with CrateDB on edge cases. Apparently, the SQL renderer of `PGCompiler` was slightly changed with SQLAlchemy 1.4, which removes a redundant space character between table name and limit clause. This slipped through because CI did not test on SA13 appropriately at the time the change was added.
hammerhead
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A flaw with the SQLAlchemy installer for CI has been discovered when running tests on GH-485. It says »Using SQLAlchemy version: 1.4.45« here 1, while the test matrix slot says it should actually be SA13.
Reason
The order of operations was wrong. So, previously, the process would always install SQLAlchemy 1.4, effectively skipping testing on SQLAlchemy 1.3.
Trivia
Indeed, another fix was needed to compensate for bringing back SA13: 4532ef7 started using the
PGCompilerfor renderingLIMITclauses, which apparently received a fix with SA14. So, 36a99ca was needed to make one of our test cases compatible with SA13 again.Footnotes
https://github.com/crate/crate-python/actions/runs/3754133520/jobs/6378077603#step:4:222 ↩